[igt-dev] [RFC i-g-t 1/1] i915/pm_backlight: turn on dpms before backlight fade out and fade in

[Chris Wilson]

Quoting Chegondi, Harish (2019-04-03 01:47:09)
> On Thu, 2019-03-14 at 07:46 +0000, Chris Wilson wrote:
> > Quoting Harish Chegondi (2019-03-14 06:41:48)
> > > backlight fade with suspend test turns off dpms which turns off
> > > the edp backlight and panel. Then it does a runtime suspend,
> > > system suspend and resume. After resume, it does a fade out and
> > > fade in of the backlight brightness. From the dmesg logs of the
> > > ci tests it appears that the test is setting the brightness
> > > even before the edp panel and backlight are turned on resuilting
> > > in the brightness values written and read to be different.
> > > Turn on the dpms which turns on the edp panel and backlight
> > > before backlight fade out and fade in. With this change the
> > > fade_with_suspend test passes.
> 
> Chris,
> 
> My commit message was confusing. I will redo the commit message in the
> next version of my patch.
> 
> > 
> > But is it legal for the kernel to that? Is the kernel meant to
> > restore
> > the previous configuration upon resume or leave it to userspace? What
> > about for fbcon?
> 
> Yes, the kernel is meant to restore the previous configuration upon
> resume.

Are you sure?

We send a hotplug to userspace to tell them to restore the configuration
as they see fit (because the configuration will often change). If fbcon
is active, it restores the fbcon screen which can just be the consequence
of handling its hotplug event.
-Chris