[igt-dev] [PATCH i-g-t] tests/kms_color: Use igt_require more

Daniel Vetter daniel.vetter at ffwll.ch
Wed Apr 3 13:50:42 UTC 2019


Success is not the right status if the test does nothing. Fix that.

Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Mika Kahola <mika.kahola at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 tests/kms_color.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2a680e..d2352cf8a9ba 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -1135,8 +1135,7 @@ invalid_ctm_matrix_sizes(data_t *data)
 	igt_pipe_t *pipe = &display->pipes[0];
 	void *ptr;
 
-	if (!igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM))
-		return;
+	igt_require(igt_pipe_obj_has_prop(pipe, IGT_CRTC_CTM));
 
 	ptr = malloc(sizeof(struct _drm_color_ctm) * 4);
 
-- 
2.20.1



More information about the igt-dev mailing list