[igt-dev] [PATCH i-g-t] tests/kms_flip: Improve asserts for expired vblank tests

Daniel Vetter daniel.vetter at ffwll.ch
Thu Apr 4 11:33:00 UTC 2019


Step 1 in debugging: Actually understand what's going wrong.

References: https://bugs.freedesktop.org/show_bug.cgi?id=102887
Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Cc: "Peres, Martin" <martin.peres at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
 tests/kms_flip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index dfa5a69e8f28..7c2aa0c02a0e 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -681,7 +681,7 @@ static unsigned int run_test_step(struct test_output *o)
 					    TEST_VBLANK_BLOCK, o->pipe, exp_seq,
 					    0, &reply));
 		igt_assert(gettime_us() - start < 500);
-		igt_assert(reply.sequence == exp_seq);
+		igt_assert_eq(reply.sequence, exp_seq);
 		igt_assert(timercmp(&reply.ts, &o->flip_state.last_ts, ==));
 	}
 
-- 
2.20.1



More information about the igt-dev mailing list