[igt-dev] [PATCH 2/4] gem_exec_parallel: do not special case the default

Chris Wilson chris at chris-wilson.co.uk
Thu Apr 4 22:57:01 UTC 2019


Quoting Lucas De Marchi (2019-04-04 23:39:23)
> A default makes sense when it's the most used.

It's not the most used name...
 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  tests/i915/gem_exec_parallel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
> index a6fa698e..f8320c3a 100644
> --- a/tests/i915/gem_exec_parallel.c
> +++ b/tests/i915/gem_exec_parallel.c
> @@ -231,7 +231,7 @@ igt_main
>                 const char *name;
>                 unsigned flags;
>         } modes[] = {
> -               { "", 0 },
> +               { "basic", 0 },
>                 { "contexts", CONTEXTS },
>                 { "fds", FDS },
>                 { NULL }
> @@ -246,7 +246,7 @@ igt_main
>         }
>  
>         for (const struct mode *m = modes; m->name; m++)
> -               igt_subtest_f("%s", *m->name ? m->name : "basic")
> +               igt_subtest_f("%s", m->name)
>                         all(fd, ALL_ENGINES, m->flags);

It gets used again where basic should not be added.
-Chris


More information about the igt-dev mailing list