[igt-dev] [PATCH i-g-t] tests/i915/gem_mmap: test for non pagealingned mmaps

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Apr 8 16:18:34 UTC 2019


On 08/04/2019 17:10, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-08 17:01:00)
>>
>> On 08/04/2019 16:50, Ramalingam C wrote:
>>> Kernel supports the non page aligned mmaps. Hence this new subtest
>>
>> s/Kernel/i915/ to make Chris happy. Maybe also expand with "by mistake"
>> and clarify this applies only to CPU WC mmap flavour.

I need to correct myself, it applies to all CPU mmap flavours. So the 
test would need to test both strictly speaking.

>>
>> Unless Chris is objecting to testing this to start with?
> 
> Correct. This is not behaviour we expect to be enshrined in the ABI for
> future generations.

One could argue that since vm_mmap silently aligns it is the Linux ABI. 
And we did have an user report for the regression.

But if we have reached another impasse, my suggestion is that Ram just 
closes the assigned ticked with RESOLVED/WONTFIX, references the mailing 
list discussion, and moves on. It's not worth the hassle.

Regards,

Tvrtko


More information about the igt-dev mailing list