[igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Check supported pixel format

Kahola, Mika mika.kahola at intel.com
Wed Apr 10 07:22:31 UTC 2019


Pushed. Thanks for the review!

On Tue, 2019-04-09 at 15:52 +0300, Ville Syrjälä wrote:
> On Tue, Apr 09, 2019 at 03:29:30PM +0300, Mika Kahola wrote:
> > Let's add a check for supported pixel format. Otherwise, we fail
> > the test,
> > for example, with the following error message
> > 
> > "[drm:intel_framebuffer_init [i915]] unsupported pixel format Y210
> > little-endian
> > (0x30313259) / modifier 0x100000000000003"
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> > Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> > ---
> >  tests/kms_plane_scaling.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> > index bb14b2cd..e843bf86 100644
> > --- a/tests/kms_plane_scaling.c
> > +++ b/tests/kms_plane_scaling.c
> > @@ -232,7 +232,8 @@ static void
> > test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe,
> > igt_ou
> >  			for (int j = 0; j < plane->drm_plane-
> > >count_formats; j++) {
> >  				uint32_t format = plane->drm_plane-
> > >formats[j];
> >  
> > -				if (igt_fb_supported_format(format))
> > +				if (igt_fb_supported_format(format) &&
> > +				    igt_plane_has_format_mod(plane,
> > format, tiling))
> >  					check_scaling_pipe_plane_rot(d,
> > plane,
> >  								     fo
> > rmat, tiling,
> >  								     pi
> > pe, output, IGT_ROTATION_0);
> > -- 
> > 2.17.1
> 
> 


More information about the igt-dev mailing list