[igt-dev] [PATCH v22 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class

Andi Shyti andi.shyti at intel.com
Wed Apr 17 09:42:40 UTC 2019


> > Engines referred by class and instance are getting more populare,
> > gem_engine_can_store_dword() should handle the situation.
> > 
> > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Signed-off-by: Andi Shyti <andi.shyti at intel.com>
> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> I would suggest we should
> s/gem_can_store_dword/gem_engine_can_store_dword/

sure, but this has to be a different patch, gem_can_store_dword
is used by too many tests.

> (and move it out of
> igt_gt.c, we are gradually making that i915/)
> and call this gem_engine_class_can_store_dword()

You want to move it to engine_topology? is it pertinent? Or do we
want to start a new gem_igt_gt?

Andi


More information about the igt-dev mailing list