[igt-dev] [PATCH i-g-t v2 5/8] lib/igt_core: Just use igt_can_fail() in __igt_run_subtest()

[Daniel Vetter]

On Tue, Apr 16, 2019 at 07:25:45PM -0400, Lyude wrote:
> From: Lyude Paul <lyude at redhat.com>
> 
> That's what it's there for.
> 
> Signed-off-by: Lyude Paul <lyude at redhat.com>
> ---
>  lib/igt_core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index a637b94e..503503ce 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -903,9 +903,7 @@ bool __igt_run_subtest(const char *subtest_name)
>  {
>  	int i;
>  
> -	igt_internal_assert(!in_subtest);
> -	igt_internal_assert(!in_fixture);
> -	igt_internal_assert(test_with_subtests);
> +	igt_internal_assert(!igt_can_fail());

Nice!

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

>  
>  	/* check the subtest name only contains a-z, A-Z, 0-9, '-' and '_' */
>  	for (i = 0; subtest_name[i] != '\0'; i++)
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch