[igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

Simon Ser simon.ser at intel.com
Wed Apr 24 07:01:29 UTC 2019


The source file contains a special code-path for Clang, however this path fails
to compile:

  ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
  float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
        ^
  ../lib/igt_halffloat.h:26:6: note: previous declaration is here
  void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
       ^
  1 error generated.

This commit fixes this mismatch.

Signed-off-by: Simon Ser <simon.ser at intel.com>
---
 lib/igt_halffloat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_halffloat.c b/lib/igt_halffloat.c
index 263b28c1..08ab05fc 100644
--- a/lib/igt_halffloat.c
+++ b/lib/igt_halffloat.c
@@ -224,7 +224,7 @@ void igt_float_to_half(const float *f, uint16_t *h, unsigned int num)
 		h[i] = _float_to_half(f[i]);
 }
 
-float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
+void igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
 {
 	for (int i = 0; i < num; i++)
 		f[i] = _half_to_float(h[i]);
-- 
2.21.0



More information about the igt-dev mailing list