[igt-dev] [PATCH i-g-t] lib/igt_halffloat: fix compilation with Clang

Petri Latvala petri.latvala at intel.com
Wed Apr 24 13:26:55 UTC 2019


On Wed, Apr 24, 2019 at 12:28:42PM +0300, Petri Latvala wrote:
> On Wed, Apr 24, 2019 at 10:01:29AM +0300, Simon Ser wrote:
> > The source file contains a special code-path for Clang, however this path fails
> > to compile:
> > 
> >   ../lib/igt_halffloat.c:227:7: error: conflicting types for 'igt_half_to_float'
> >   float igt_half_to_float(const uint16_t *h, float *f, unsigned int num)
> >         ^
> >   ../lib/igt_halffloat.h:26:6: note: previous declaration is here
> >   void igt_half_to_float(const uint16_t *h, float *f, unsigned int num);
> >        ^
> >   1 error generated.
> > 
> > This commit fixes this mismatch.
> > 
> > Signed-off-by: Simon Ser <simon.ser at intel.com>
> 
> Same clang path is also used for !x86_64, as shown in the gitlab CI
> build failure.
> 
> 
> Reviewed-by: Petri Latvala <petri.latvala at intel.com>


And merged now, thanks.


More information about the igt-dev mailing list