[igt-dev] [PATCH i-g-t v3 0/9] Fixes from updating igt packaging in Fedora

Lyude lyude at redhat.com
Wed Apr 24 20:20:24 UTC 2019


From: Lyude Paul <lyude at redhat.com>

For work reasons, I've been tasked with getting Fedora running portions
of IGT in our own CI infrastructure. In doing so I needed to get our RPM
packaging up to date, building and passing the meson unit tests on
Fedora 29 and Fedora Rawhide. This ended up exposing some rather
interesting bugs, and also prompted me to update the Dockerfile and
Gitlab CI settings that we use for testing builds. So, here's my fixes
and improvements!

Since a couple of people have been asking if I have a gitlab branch that
they can check to make sure that the CI changes work, here it is:

https://gitlab.freedesktop.org/lyudess/igt-gpu-tools/tree/wip/fedora-docker-update-v3

			    Changes since v1
* Add one last patch that came out of package review - soversioning,
  which both Debian and Fedora seem to require
  (see https://bugzilla.redhat.com/show_bug.cgi?id=1700559 )

			    Changes since v2
* Don't get rid of assert() apparently, instead perma-ban
  -Db_ndebug!=false
* Fix usages of the gettid() syscall that weren't wrapped around the
  gettid() macro
* Also typecast gettid() correctly to pid_t and update users, to avoid
  introducing warnings when using new glibc's version of gettid() and
  for general correctness

Lyude Paul (9):
  lib/tests: Fix test failures with meson 0.50.0
  Use gettid() wrapper everywhere
  lib/aux: Typecast gettid() as pid_t
  meson: Don't redefine gettid if the C library provides it
  meson: Add .so versioning
  meson: Don't allow building with NDEBUG, ever
  lib/igt_core: Just use igt_can_fail() in __igt_run_subtest()
  Use pkgconfig() macros with dnf in Fedora Dockerfile
  Update Dockerfile.fedora to Fedora 29

 Dockerfile.fedora           | 50 ++++++++++++++++++-------------------
 benchmarks/gem_syslatency.c |  1 -
 lib/igt_aux.h               | 11 +++++++-
 lib/igt_core.c              |  6 ++---
 lib/igt_core.h              |  2 +-
 lib/meson.build             |  3 ++-
 meson.build                 | 13 ++++++++++
 tests/core_auth.c           |  6 ++---
 tests/drm_import_export.c   |  2 +-
 tests/i915/gem_close_race.c |  1 -
 tools/meson.build           |  3 ++-
 11 files changed, 57 insertions(+), 41 deletions(-)

-- 
2.20.1



More information about the igt-dev mailing list