[igt-dev] [PATCH i-g-t] tests/kms_properties: Fix upper bound of 'max bpc' range

Imre Deak imre.deak at intel.com
Thu Aug 8 14:02:05 UTC 2019


The available range reported by the driver is the inclusive [min_bpc,
max_bpc], so fix the upper bound used by the test accordingly. This
issue had the side-effect (on ICL for instance) of limiting 'max bpc' to
10 (instead of restoring it to the default 12) for all the tests
following kms_properties, as seen from the logs in the referenced bug
below.

Reference: https://bugs.freedesktop.org/show_bug.cgi?id=109593
Cc: Radhakrishna Sripada <radhakrishna.sripada at intel.com>
Signed-off-by: Imre Deak <imre.deak at intel.com>
---
 tests/kms_properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index eb9cbdda..18cf96e0 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -91,7 +91,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
 	if (atomic)
 		req = drmModeAtomicAlloc();
 
-	for ( i = prop->values[0]; i < prop->values[1] ; i++) {
+	for (i = prop->values[0]; i <= prop->values[1]; i++) {
 		if (!atomic) {
 			ret = drmModeObjectSetProperty(fd, id, type, prop_id, i);
 
-- 
2.17.1



More information about the igt-dev mailing list