[igt-dev] [PATCH i-g-t] lib/i915: Trim ring measurement by one
Mika Kuoppala
mika.kuoppala at linux.intel.com
Mon Aug 12 14:25:14 UTC 2019
Chris Wilson <chris at chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-08-12 12:52:56)
>> Chris Wilson <chris at chris-wilson.co.uk> writes:
>>
>> > Be a little more conservative in our ring measurement and exclude one
>> > batch to leave room in case our user needs to wrap (where a request will
>> > be expanded to cover the unused space at the end of the ring).
>> >
>>
>> did read the wrapping part and that seems to be the case that
>> we enlarge the wrapping request.
>>
>> However do we lose some coverage on the actual wrap tests?
>
> The tests where we call measure_ring_size, are those that we do not want
> to block due to running out of space (and wrapping) :)
Ok. The bugs on the wrap itself should bubble to surface
indirectly. Agreed that estimating the inflight wrong
is bad.
Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
More information about the igt-dev
mailing list