[igt-dev] [PATCH i-g-t] kms_ccs: Add the missing '\n' for igt_require_f

Ser, Simon simon.ser at intel.com
Tue Aug 13 08:00:51 UTC 2019


On Tue, 2019-08-06 at 22:02 +0100, Chris Wilson wrote:
> Currently the runner sees
> 
> Starting subtest: pipe-C-bad-aux-stride
> Test requirement not met in function test_output, file
> ../tests/kms_ccs.c:324:
> Test requirement: valid_tests > 0
> CCS not supported, skippingSubtest pipe-C-bad-aux-stride: SKIP
> (0.330s)
> 
> and manages to explode.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Simon Ser <simon.ser at intel.com>

> ---
>  tests/kms_ccs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> index 6cd30aad8..1ce66cdec 100644
> --- a/tests/kms_ccs.c
> +++ b/tests/kms_ccs.c
> @@ -321,7 +321,7 @@ static int __test_output(data_t *data)
>  static void test_output(data_t *data)
>  {
>  	int valid_tests = __test_output(data);
> -	igt_require_f(valid_tests > 0, "CCS not supported, skipping");
> +	igt_require_f(valid_tests > 0, "CCS not supported,
> skipping\n");
>  }
>  
>  static data_t data;
> @@ -373,7 +373,8 @@ igt_main
>  				valid_tests += __test_output(&data);
>  			}
>  
> -			igt_require_f(valid_tests > 0, "CCS not
> supported, skipping");
> +			igt_require_f(valid_tests > 0,
> +				      "CCS not supported, skipping\n");
>  		}
>  
>  		data.plane = NULL;


More information about the igt-dev mailing list