[igt-dev] [PATCH i-g-t] tests/igt_command_line.sh: Add new selftest for special handling

Chris Wilson chris at chris-wilson.co.uk
Tue Aug 20 08:32:05 UTC 2019


Quoting Antonio Argenziano (2019-08-19 23:31:37)
> dmabuf_selftests has been recently added to the test list but not added
> to the special handling in igt_command_line.sh and therefore build
> testing would fail.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/igt_command_line.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
> index 92643c4d..eaec1b4f 100755
> --- a/tests/igt_command_line.sh
> +++ b/tests/igt_command_line.sh
> @@ -90,7 +90,7 @@ check_test ()
>                 # Subtest enumeration of kernel selftest launchers depends
>                 # on the running kernel. If selftests are not enabled,
>                 # they will output nothing and exit with 0.
> -               if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" ]; then
> +               if [ "$testname" != "i915_selftest" -a "$testname" != "drm_mm" -a "$testname" != "kms_selftest" -a "$testname" != "dmabuf_selftests"]; then

This does not scale. What does this test even achieve as it appears not
to be the intended behaviour?
-Chris


More information about the igt-dev mailing list