[igt-dev] [PATCH v2 3/3] gitlab-ci: introduce final containers

Arkadiusz Hiler arkadiusz.hiler at intel.com
Fri Aug 23 12:56:13 UTC 2019


On Fri, Aug 23, 2019 at 03:41:03PM +0300, Vasilev, Oleg wrote:
> > > +COPY scripts/docker-help.sh /usr/local/bin/docker-help.sh
> > 
> > I would also put this one in .gitlab-ci/
> 
> This not technically CI-related, but docker-related. Why not leave it
> in scripts/?
> 
> Oleg

Because it explains how to use container when you first try to run it
without any parameters. It makes no sense outside of this scope.

If you keep it in scripts/ then someone will see it there along
run-tests.sh, will try run it and get confused :-)

-- 
Cheers,
Arek


More information about the igt-dev mailing list