[igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: update comments mentionning disconnected connectors
Ville Syrjälä
ville.syrjala at linux.intel.com
Mon Aug 26 13:15:26 UTC 2019
On Mon, Aug 26, 2019 at 04:02:38PM +0300, Simon Ser wrote:
> Comments say that a connector can only be forced if it's disconnected. This was
> a wrong assumption which has been fixed, but the comments went out of sync.
>
> Fixes: dc3a0934a177 ("tests/kms_hdmi_inject: Accept any HDMI connector")
> Signed-off-by: Simon Ser <simon.ser at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> tests/kms_hdmi_inject.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index 521105062dad..d9ab4095b8c5 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -34,9 +34,9 @@
> #define VDISPLAY_4K 2160
>
> IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
> - "expected results by forcing a disconnected HDMI "
> - "connector with a known EDID and checking that the "
> - "metadata exposed to user space matches.");
> + "expected results by forcing a HDMI connector "
> + "with a known EDID and checking that the metadata "
> + "exposed to user space matches.");
>
> /**
> * This collection of tests performs EDID and status injection tests. Injection
> @@ -49,8 +49,6 @@ IGT_TEST_DESCRIPTION("Test that in-kernel EDID parsing is producing "
> * - 4K modes exposed via KMS
> * - Audio capabilities of the monitor exposed via ALSA. EDID-Like Data (ELD)
> * entries in /proc/asound are verified.
> - *
> - * Injection is performed on a disconnected connector.
> */
>
> /** get_connector: get the first disconnected HDMI connector */
> --
> 2.23.0
--
Ville Syrjälä
Intel
More information about the igt-dev
mailing list