[igt-dev] [PATCH i-g-t 2/2] lib/igt_fb: sync memory at unmap_bo()

[Chris Wilson]

Quoting Juha-Pekka Heikkila (2019-12-04 15:52:49)
> Sync memory at unmap_bo() to avoid problems with cpu gem domain.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
>  lib/igt_fb.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 6ce7cfe..5a70dbf 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2152,6 +2152,10 @@ int igt_dirty_fb(int fd, struct igt_fb *fb)
>  
>  static void unmap_bo(struct igt_fb *fb, void *ptr)
>  {
> +       if (is_i915_device(fb->fd))
> +               gem_set_domain(fb->fd, fb->gem_handle,
> +                              I915_GEM_DOMAIN_GTT, 0);
> +

What? How is this not papering over random bugs?
-Chris