[igt-dev] [PATCH i-g-t v4] tests/i915/gem_mmap_offset: add new tests to extend coverage

Chris Wilson chris at chris-wilson.co.uk
Tue Dec 10 11:09:53 UTC 2019


Quoting Zbigniew Kempczyński (2019-12-10 10:15:19)
> +               ret = create_ioctl(i915, &create);
> +               if (!ret) {
> +                       ptr = __mmap_offset(i915, create.handle, 0, create.size,
> +                                           PROT_READ | PROT_WRITE,
> +                                           t->type);
> +                       /*
> +                        * gem_create succeed, but we're not able to mmap bo.
> +                        * We mark path as failed and we have to change memory
> +                        * allocation constraints.
> +                        */
> +                       if (!ptr) {
> +                               ret = -1;
> +                               gem_close(i915, create.handle);
> +                       }

There's still no actual size validation along this path :)

The first point at which we will actually get around to validating
placement & access path is on the pagefault, and that will probably
necessitate either partial object views in the fault handler or
migration.
-Chris


More information about the igt-dev mailing list