[igt-dev] [PATCH i-g-t] tests/kms_color: Add 10bpc frame buffer parameterization to subtests

[Ville Syrjälä]

On Thu, Dec 12, 2019 at 03:53:34PM -0500, Leo wrote:
> 
> 
> On 2019-12-12 10:03 a.m., Ville Syrjälä wrote:
> > On Wed, Dec 11, 2019 at 03:46:36PM -0500, sunpeng.li at amd.com wrote:
> >> From: Leo Li <sunpeng.li at amd.com>
> >>
> >> We'd like to test the hardware pipe's color management with 10bit
> >> surfaces.
> > 
> > Why exactly? The pipe color management stuff doesn't care what
> > pixel format the plane used.
> > 
> 
> We expose 10bpc support to usermode with color management, so it'd be
> good to cover it with a test.
> 
> With amdpgu, color management indeed doesn't care about surface format,
> since it's all converted to fixed point in hardware beforehand.

Totally missed this came from AMD folks. Good thing I was still
correct with my statement then :)

> But I
> think it's best to not assume hardware behavior, and test the actual
> use case instead.

I think what we would really want is a test that makes sure we can
achieve the desired precision in the output for some fb depth and
gamma configuration (sadly the gamma uapi doesn't let us do that
ATM in a hardware agnostic way). I don't think this test currently
checks anything like that. But maybe I'm misremebering what it
actually does.

-- 
Ville Syrjälä
Intel