[igt-dev] [PATCH i-g-t 1/1] intel-gpu-top: Support for client stats

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 16 13:26:51 UTC 2019


Quoting Tvrtko Ursulin (2019-12-16 12:09:23)
> +static void __restore_stats(void)
> +{
> +       int ret;
> +
> +       if (__stats_enabled)
> +               return;
> +
> +       ret = __set_stats(false);

Therein lies the problem with a global toggle. :(

Hmm, if our stats toggling is always in process_csb() responding to
events, they shouldn't affect execution latency... I think you have made
them cheap enough to consider always enabling. Let's see.
-Chris


More information about the igt-dev mailing list