[igt-dev] [PATCH i-g-t 1/1] tests/i915/gem_fence: platforms not supporting fences

Katarzyna Dec katarzyna.dec at intel.com
Mon Dec 30 08:00:33 UTC 2019


On Fri, Dec 20, 2019 at 07:55:15PM +0530, Nayana, Venkata Ramana wrote:
> For platforms not supporting fences(no aperture), skip tests
> 
> Cc: Dec, Katarzyna <katarzyna.dec at intel.com>
> Cc: Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com>
> Signed-off-by: Nayana, Venkata Ramana <venkata.ramana.nayana at intel.com>
> Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> ---
>  tests/i915/gem_fence_thrash.c       | 2 +-
>  tests/i915/gem_fenced_exec_thrash.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_fence_thrash.c b/tests/i915/gem_fence_thrash.c
> index c85c38bb..9beada98 100644
> --- a/tests/i915/gem_fence_thrash.c
> +++ b/tests/i915/gem_fence_thrash.c
> @@ -203,7 +203,7 @@ static int run_test(int threads_per_fence, void *f, int tiling,
>  	t.num_surfaces = surfaces_per_thread;
>  
>  	num_fences = gem_available_fences(t.fd);
> -	igt_assert_lt(0, num_fences);
> +	igt_require(num_fences > 0);
>  
>  	num_threads = threads_per_fence * num_fences;
>  
> diff --git a/tests/i915/gem_fenced_exec_thrash.c b/tests/i915/gem_fenced_exec_thrash.c
> index e40fa438..db1b15aa 100644
> --- a/tests/i915/gem_fenced_exec_thrash.c
> +++ b/tests/i915/gem_fenced_exec_thrash.c
> @@ -165,7 +165,7 @@ igt_main
>  		igt_require_gem(fd);
>  
>  		num_fences = gem_available_fences(fd);
> -		igt_assert(num_fences > 4);
> +		igt_require(num_fences > 4);
>  		igt_assert(num_fences <= MAX_FENCES);
>  
>  		devid = intel_get_drm_devid(fd);
> -- 
> 2.24.0
>
This is not first version of this patch - next time (for new series) add which
version while generating patch (e.g. 'git format-patch -v2') and include change
log in commit msg:
v2: Removed X, Added Y

This patch was acked by Zbigniew. It looks good, so I think we can merge it.
Reviewed-by: Katarzyna Dec <katarzyna.dec at intel.com>

Kasia :)


More information about the igt-dev mailing list