[igt-dev] [Intel-gfx] [PATCH i-g-t] i915/perf_pmu: Add trailing '\n' to an igt_assert_f

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Feb 4 09:14:11 UTC 2019


On 02/02/2019 22:36, Chris Wilson wrote:
> A missing newline at the end of an assert, so add it for clarity in the
> error message.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   tests/i915/perf_pmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 391378139..c3993c417 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -707,7 +707,7 @@ sema_wait(int gem_fd, const struct intel_execution_engine2 *e,
>   	} while (!obj_ptr[1]);
>   
>   	igt_assert_f(igt_wait(pmu_read_single(fd) != val[0], 10, 1),
> -		     "sampling failed to start withing 10ms");
> +		     "sampling failed to start withing 10ms\n");
>   
>   	val[0] = __pmu_read_single(fd, &ts[0]);
>   	slept = measured_usleep(batch_duration_ns / 1000);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the igt-dev mailing list