[igt-dev] [RFC PATCH v6 3/4] lib: ioctl_wrappers: reach engines by index as well

[Chris Wilson]

Quoting Andi Shyti (2019-02-06 09:18:49)
> With the new engine query method engines are reachable through
> an index and context they are combined with.
> 
> The 'gem_has_ring()' becomes 'gem_has_ring_by_idx()' that
> requires the index that the engine is mapped with in the driver.
> 
> The previous function becomes a wrapper to the new
> 'gem_has_ring_by_idx()'.
> ---
>  lib/ioctl_wrappers.c | 10 ++++++----
>  lib/ioctl_wrappers.h |  4 +++-
>  2 files changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
> index 57ed8c51bea5..5c908f4a35a5 100644
> --- a/lib/ioctl_wrappers.c
> +++ b/lib/ioctl_wrappers.c
> @@ -1468,14 +1468,14 @@ void igt_require_gem(int fd)
>         igt_require_f(err == 0, "Unresponsive i915/GEM device\n");
>  }
>  
> -bool gem_has_ring(int fd, unsigned ring)
> +bool gem_has_ring_by_idx(int fd, unsigned flags, unsigned rsvd1)

Don't conflate the ABIs? We either use index or the mismash.
by_index *does* not use the flags...
-Chris