[igt-dev] [PATCH i-g-t] tests/i915/gem_mmap_wc: Adjust loop to OBJECT_SIZE

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 7 08:41:01 UTC 2019


Quoting Katarzyna Dec (2019-02-07 08:34:44)
> On Thu, Feb 07, 2019 at 08:11:28AM +0000, Chris Wilson wrote:
> > Quoting Katarzyna Dec (2019-02-07 08:08:04)
> > > When we run test with INTEL_SIMULATION=1 we set OBJECT_SIZE
> > > to 1M which is not reflected in test_close() loop.
> > 
> > Why would you bother running this test on simulation? It's just a test
> > of the kernel reference counting.
> > -Chris
> So why do we have different object size for simulation in this test when we
> should not bother?

No idea. All hw interaction should be covered by selftests (this
certainly is), the raison d'etre for igt is to cover user observable
behaviour. For the simulator, we should just be able to use seftests
followed by bare uABI checks before moving onto real workloads.

> Btw - I am fixing a bug in your code.

Nope, that is nothing to do with me. Someone else thought is was a good
idea. I do not like having tests vary, make different tests.
-Chris


More information about the igt-dev mailing list