[igt-dev] [RFC PATCH v6 2/4] lib: implement new engine discovery interface

[Chris Wilson]

Quoting Andi Shyti (2019-02-08 11:03:21)
> Hi Antonio,
> 
> > > A new function gem_init_engine_list() is addedthat is called
> > 
> > nit: missing white space ^^^^^^^^^^^^^^^^^^^^^
> 
> Thanks :)
> 
> > > +   igt_assert(!igt_ioctl(fd,
> > > +                         DRM_IOCTL_I915_GEM_CONTEXT_SETPARAM, &ctx_param));
> > 
> > It would be good to have a wrapper for assigning the context to an engine
> > instance and then another wrapper (or maybe a macro) for assigning the
> > context to all engines, so not to hide the intent of the IOCLT underneath. I
> > assume tests will want to have contexts assigned only to some engines and
> > not others.
> 
> yes, that's the same thing Chris pointed out, I'll put everything
> into a macro.

Not macros! Functions. The macros get stringified in all their
glory making the failure message hideous and unreadable.

The functions should already exist, for the most part at least.
-Chris