[igt-dev] [PATCH i-g-t] i915/gem_exec_parallel: Add skip_on_simulation to whole binary

Katarzyna Dec katarzyna.dec at intel.com
Fri Feb 8 13:23:59 UTC 2019


On Fri, Feb 08, 2019 at 01:14:26PM +0000, Chris Wilson wrote:
> Quoting Katarzyna Dec (2019-02-08 13:10:37)
> > On simulation environment these tests were failing. During debug
> > we decided that whole binary should be skipped, because there is
> > no additional coverage in simulation.
> 
> How did they fail? There are some paths here that are rarely touched
> elsewhere.
> -Chris
I like you challenges Chris :)

gem_exec_parallel@*context* were failing with error:

(gem_exec_parallel:1245) ioctl_wrappers-CRITICAL: Test assertion failure
function gem_execbuf, file ../lib/ioctl_wrappers.c:605:
(gem_exec_parallel:1245) ioctl_wrappers-CRITICAL: Failed assertion:
__gem_execbuf(fd, execbuf) == 0
(gem_exec_parallel:1245) ioctl_wrappers-CRITICAL: error: -28 != 0

and @*fds* with:

(gem_exec_parallel:1315) igt_debugfs-CRITICAL: Last errno: 24, Too many open
files

After discussion with Ursulin Tvrtko we decided that it is redundant to run it
on simulation.
Probably my commit msg was lacking some information.

Kasia :)


More information about the igt-dev mailing list