[igt-dev] [PATCH i-g-t] i915/query: Enable QUERY_TOPOLOGY_INFO for all gens

Stuart Summers stuart.summers at intel.com
Sat Feb 9 00:11:46 UTC 2019


Currently the QUERY_TOPOLOGY_INFO IOCTL is only being tested on haswell,
broadwell, skylake, kabylake, and coffeelake. The i915 driver doesn't
prevent other platforms from accessing this ioctl, so modify IGT to at
least test the interface, even if the platform/gen doesn't contain multiple
GTs.

Signed-off-by: Stuart Summers <stuart.summers at intel.com>
---
 tests/i915/query.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/tests/i915/query.c b/tests/i915/query.c
index 3e7fd140..e4757661 100644
--- a/tests/i915/query.c
+++ b/tests/i915/query.c
@@ -428,9 +428,6 @@ test_query_topology_known_pci_ids(int fd, int devid)
 	int n_slices = 0, n_subslices = 0;
 	int s, ss;
 
-	/* The GT size on some Broadwell skus is not defined, skip those. */
-	igt_skip_on(dev_info->gt == 0);
-
 	memset(&item, 0, sizeof(item));
 	item.query_id = DRM_I915_QUERY_TOPOLOGY_INFO;
 	i915_query_items(fd, &item, 1);
@@ -477,7 +474,8 @@ test_query_topology_known_pci_ids(int fd, int devid)
 		igt_assert_eq(n_subslices, 3 * 3);
 		break;
 	default:
-		igt_assert(false);
+		/* nothing to check */
+		break;
 	}
 
 	free(topo_info);
@@ -524,9 +522,6 @@ igt_main
 
 	igt_subtest("query-topology-known-pci-ids") {
 		igt_require(query_topology_supported(fd));
-		igt_require(IS_HASWELL(devid) || IS_BROADWELL(devid) ||
-			    IS_SKYLAKE(devid) || IS_KABYLAKE(devid) ||
-			    IS_COFFEELAKE(devid));
 		test_query_topology_known_pci_ids(fd, devid);
 	}
 
-- 
2.20.1



More information about the igt-dev mailing list