[igt-dev] [PATCH i-g-t] i915/query: Enable QUERY_TOPOLOGY_INFO for all gens

[Chris Wilson]

Quoting Summers, Stuart (2019-02-09 00:32:06)
> On Sat, 2019-02-09 at 00:21 +0000, Chris Wilson wrote:
> > Quoting Stuart Summers (2019-02-09 00:11:46)
> > > Currently the QUERY_TOPOLOGY_INFO IOCTL is only being tested on
> > > haswell,
> > > broadwell, skylake, kabylake, and coffeelake.
> > 
> > No, it's tested everywhere it's supported across the other tests.
> > Only
> > this particular test is skipped if there is no hardcoded truth value
> > as 
> > only a small number of known pci-ids are supplied.
> > 
> > Skip is the more accurate result (since the test is not doing
> > anything it
> > sets out to do, and tests should be reasonably succinct), but you
> > could
> > move the skip down into the switch() so that we don't repeat
> > ourselves.
> 
> My reasoning for removing this was to exercise the asserts we are
> calling within i915_query_items() for those platforms which do not
> implement dev_info->gt. So we are checking something here, even if it
> doesn't specifically analyze the slices/subslices for each platform.

But they are already covered. This test is very specifically about
comparing the reported topology for a small set of known topologies and
verifying they match.
-Chris