[igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_mmap_gtt: Impose a timeout for "hang"

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Feb 12 10:56:13 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Only wait a maximum of 2 more seconds for the hang children to complete,
> to catch deadlocks in a timely fashion.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> ---
>  tests/i915/gem_mmap_gtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index f9d811ad6..f6fbbe193 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -450,7 +450,7 @@ test_hang(int fd)
>  	igt_info("%lu resets\n", count);
>  
>  	control->done = true;
> -	igt_waitchildren();
> +	igt_waitchildren_timeout(2, NULL);

Seems that no-one is using the reason argument. You could have
been the first ever!

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

>  
>  	igt_assert(!control->error);
>  	munmap(control, 4096);
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the igt-dev mailing list