[igt-dev] [RFC PATCH v7 3/5] lib: ioctl_wrappers: check GET/SETPARAM ioctl and build active engine list

Andi Shyti andi.shyti at intel.com
Tue Feb 12 09:07:30 UTC 2019


Hi Chris,

On Mon, Feb 11, 2019 at 11:16:42PM +0000, Chris Wilson wrote:
> Quoting Andi Shyti (2019-02-11 23:08:09)
> > The igt_require_gem_engine_list() is called whenever the test
> > wants to use the GET/SETPARAM ioctls.
> > 
> > The function checks whether the GET/SETPARAM are implemented in
> > the running kernel and stops the test in case these commands are
> > not supported.
> > 
> > At the first call it creates the current engine list as
> > implemented in the gem_init_engine_list() function.
> > 
> > Signed-off-by: Andi Shyti <andi.shyti at intel.com>
> > ---
> >  lib/ioctl_wrappers.c | 7 +++++++
> >  lib/ioctl_wrappers.h | 1 +
> 
> No new additions to ioctl_wrappers.c please. If we are generalising an
> existing interface, pull it out into i915/ and add your additions there.

for both the reviews: I will move then everything in i915/.

Thanks again!
Andi


More information about the igt-dev mailing list