[igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Wed Feb 13 15:15:06 UTC 2019


Hey,

Op 29-01-2019 om 15:08 schreef swati2.sharma at intel.com:
> From: Swati Sharma <swati2.sharma at intel.com>
>
> Existing kms_color i-g-t, commit style by default is legacy for
> all the ctm/gamma/degamma subtests.
>
> In this patch, provision for both legacy and atomic commit is
> provided. Patch is floated as RFC to gather feedback on the idea
> and infrastructure proposed.
>
> Other approach could be getting the value of is_atomic as done in
> kms_available_modes_crc like
> data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY
> However with this approach we won't be able to test both the paths.
>
> v1: As per Daniel's comments switching over to atomic.
> v2: Rebase
>
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>


Just do COMMIT_ATOMIC, and add igt_require(display.is_atomic), drivers should support it for this test. :)

~Maarten



More information about the igt-dev mailing list