[igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev7)

[Petri Latvala]

On Tue, Feb 12, 2019 at 08:43:24AM +0000, Tvrtko Ursulin wrote:
> Is generating subtest names without accessing the driver an absolute
> requirement?

Yes.


> This particular failure would be fixable if the engine list was initialized
> on the first call to __for_each_engine_class_instance, as called by the
> perf_pmu above. And the fixture block is already ran in test enumeration,
> where the driver is opened. I think a lot of tests are like this. So in this
> context a simple query ioctl on top doesn't sound bad.

Fixtures are not executed when enumerating tests.


> I think it would be simpler if we didn't have to maintain a separate static
> list of all possible engines. To make that work we would need to detect the
> mode of execution (list vs execute) in the engine iterator as well. So gain,
> to me it sounds preferable that tests would be allowed to enumerate
> dynamically.

Can the tests be refactored to have a subtest per engine _class_?
That's a static list, isn't it? Within the subtest they would loop
over instances of the class. Kind of like tests that loop over
connectors of $type.


-- 
Petri Latvala