[igt-dev] [Intel-gfx] [PATCH i-g-t 2/2] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

Chris Wilson chris at chris-wilson.co.uk
Mon Feb 18 12:56:28 UTC 2019


Quoting Mika Kuoppala (2019-02-18 12:49:31)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > When RECOVERABLE is set, the kernel will attempt to automatically recover
> > a context after a hang. But if it is unset, the kernel will ban the
> > guilty context on a hang, preventing subsequent execution.
> >
> > v2: Create a has_recoverable_param()
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at intel.com>
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> 
> Not a topic for this testcase but just brought up thoughts
> that we could reap ppgtt and some selected bits in driver
> when we ban. Perhaps a future exercise.

Interesting thought. What I would suggest is that you replace the
file_priv->context_idr entry with a stub and then the old context and
gubbins will die naturally as soon as the requests disappear.

As you can't acquire the lock inside reset, you would need to queue a
worker to fixup the idr later.
-Chris


More information about the igt-dev mailing list