[igt-dev] [PATCH i-g-t 3/3] tests: Prefix pm_ tests with i915_ and move them to i915/

Arkadiusz Hiler arkadiusz.hiler at intel.com
Wed Feb 20 11:20:48 UTC 2019


On Wed, Feb 20, 2019 at 12:04:08PM +0200, Jani Nikula wrote:
> On Tue, 19 Feb 2019, Arkadiusz Hiler <arkadiusz.hiler at intel.com> wrote:
> > They are i915-specific, so they belong to the directory.
> > The (now) infix _pm_ is quite informative and worth keeping.
> 
> Too late to the party and I'm sure I'm missing something. But...
> 
> It does feel like moving things in i915 directory *and* prefixing with
> i915 is an unnecessary tautology. Why not just one or the other?

I am not a fan of this redundancy either, but it makes sense with some
context. Let me explain:

 * i915/ so that `ls` ouput  is more digestible. We also have gem_ and
   gen3_ tests there that are not i915_ prefixed.

 * i915_ so that binary name corresponds to .c file, makes test lookup
   easier.

Of all the considered options this seem to make the most people happy.

-- 
Cheers,
Arek


More information about the igt-dev mailing list