[igt-dev] [PATCH i-g-t 5/5] lib/tests: Add testcase for nonexisting subtest name

[Arkadiusz Hiler]

On Tue, Feb 19, 2019 at 08:57:16AM +0100, Daniel Vetter wrote:
> While at it, convert the existing testcase for invalid subtest names
> to a positive one.
> 
> This is the only thing the invalid subtest checking for all tests did
> cover, which wasn't covered through some other checks already.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  lib/tests/igt_invalid_subtest_name.c | 62 +++++++++++++++++++++++++++-
>  lib/tests/meson.build                |  2 +-
>  2 files changed, 62 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/tests/igt_invalid_subtest_name.c b/lib/tests/igt_invalid_subtest_name.c
> index 418071da0591..f962e0df0121 100644
> --- a/lib/tests/igt_invalid_subtest_name.c
> +++ b/lib/tests/igt_invalid_subtest_name.c
> @@ -21,11 +21,71 @@
>   * IN THE SOFTWARE.
>   */
>  
> +#include <errno.h>
> +#include <sys/wait.h>
> +
>  #include "igt_core.h"
>  
> -igt_main
> +#include "igt_tests_common.h"
> +
> +static void invalid_subtest_name(void)
>  {
> +	char prog[] = "igt_no_exit";
> +	char *fake_argv[] = {prog};
> +	int fake_argc = 1;

Same thing with ARRAY_SIZE as in 4/5, but that in those trivial cases
it's just sugar.

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>