[igt-dev] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 21 10:19:43 UTC 2019


To control hang detection, we manipulate the i915.reset module
parameter. However, to be nice we should SKIP if we cannot modify the
parameter as opposed to outright FAILing.

References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 lib/igt_gt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 646696727..c98a7553b 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
 	if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
 		igt_require(has_gpu_reset(fd));
 
-	igt_assert(igt_sysfs_set_parameter
-		   (fd, "reset", "%d", INT_MAX /* any reset method */));
+	igt_require(igt_sysfs_set_parameter
+		    (fd, "reset", "%d", INT_MAX /* any reset method */));
 
 	if ((flags & HANG_ALLOW_CAPTURE) == 0) {
 		param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
-- 
2.20.1



More information about the igt-dev mailing list