[igt-dev] [PATCH i-g-t v1] meson: missed dependency of liblzma

[Sergii Romantsov]

Hello, Petri.


> As I understood you, just installing liblzma-dev makes the build
> successful, right?


If to be more specific, installing liblzma-dev makes meson-configuration
successful.

Making this change just lead to better error messages when it's not
> installed?


Yes, it will show which package exactly leaked instead of unclear error.

What is the distro you're using?


4.15.0-45-generic #48~16.04.1-Ubuntu SMP Tue Jan 29 18:03:48 UTC 2019
x86_64 x86_64 x86_64 GNU/Linux

I think it happens due to specific of meson-dependency - how it looks for a
package.
So command (when liblzma-dev is absent, but liblzma5 is installed)
 'pkg-config --cflags --libs libdw'
gives:
"Package liblzma was not found in the pkg-config search path.
Perhaps you should add the directory containing `liblzma.pc'
to the PKG_CONFIG_PATH environment variable
Package 'liblzma', required by 'libdw', not found"

So in my understanding its just because of lack of liblzma.pc

On Tue, Feb 26, 2019 at 11:46 AM Petri Latvala <petri.latvala at intel.com>
wrote:

> On Mon, Feb 25, 2019 at 03:23:19PM +0200, Sergii Romantsov wrote:
> > Failed to configure intel-gpu-tools with error:
> >
> >       meson.build:151:0: ERROR:  Could not generate cargs for libdw:
> >
> > libdw depends on liblzma.
> > Installation of liblzma-dev fixes issue.
> >
> > Fixes: e39e09910fc8 (lib/core: Use libdw to decode stack trace with
> debugging symbols, v2.)
> > CC: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
> > ---
> >  meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meson.build b/meson.build
> > index 099db89..4c58ca8 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -148,6 +148,7 @@ if with_libunwind != 'false'
> >  endif
> >  build_info += 'With libunwind: ' + libunwindinfo
> >
> > +liblzma = dependency('liblzma', required : true)
>
> _We_ don't use liblzma for anything though, so this is kind of
> superfluous. As I understood you, just installing liblzma-dev makes
> the build successful, right? Making this change just lead to better
> error messages when it's not installed?
>
> What is the distro you're using? The ones we build-test on in gitlab
> CI (Fedora, Debian) both have libdw's development package depend on
> liblzma.
>
>
> --
> Petri Latvala
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20190226/2b8da447/attachment.html>