[igt-dev] [PATCH i-g-t] meson: Make doc building dependent on gtk-doc

[Arkadiusz Hiler]

On Thu, Feb 28, 2019 at 12:59:55PM +0200, Petri Latvala wrote:
> On Wed, Feb 27, 2019 at 08:06:43PM +0200, Arkadiusz Hiler wrote:
> > Currently, when gtk-doc is not installed 'ninja' succeeds but
> > 'ninja install' fails with the following error:
> > 
> >    FileNotFoundError: [Errno 2] No such file or directory: 'gtkdoc-scan': 'gtkdoc-scan'
> > 
> > With this patch 'meson build' will log that documentations would not
> > build and 'ninja install' will succeed.
> > 
> > When forcing building docs with 'meson -Dbuild_docs=true build' the
> > following error will occur instead:
> > 
> >   meson.build:323:0: ERROR:  Dependency "gtk-doc" not found, tried pkgconfig and cmake
> > 
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > Reported-by: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> 
> Reviewed-by: Petri Latvala <petri.latvala at intel.com>
> 
> The gtk_doc dependency object is left unused, doc building uses
> import('gnome') instead for it, but hey.

Yeah, I am surprised thta gnome.gtkdoc() is not clever enough, doesn't
do any dependency checks and lacks 'required' flag.

They have an issue on that since 0.45.1 in Meson.

Anyway, thanks for the review. Pushing in a moment.