[igt-dev] [PATCH i-g-t 1/5] lib/i915: Assert mmap size alignment

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 28 14:24:07 UTC 2019


Quoting Tvrtko Ursulin (2019-02-28 14:18:24)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> mmap(2) mandates size is page aligned so check this in our wrappers.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>  lib/i915/gem_mman.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/i915/gem_mman.c b/lib/i915/gem_mman.c
> index 3cf9a6bbdb31..084dbb3b3678 100644
> --- a/lib/i915/gem_mman.c
> +++ b/lib/i915/gem_mman.c
> @@ -57,6 +57,8 @@ void *__gem_mmap__gtt(int fd, uint32_t handle, uint64_t size, unsigned prot)
>         struct drm_i915_gem_mmap_gtt mmap_arg;
>         void *ptr;
>  
> +       igt_assert(!(size & 4095));

No, we don't filter what the kernel gets, not in the ioctl wrapper
itself.
-Chris


More information about the igt-dev mailing list