[igt-dev] [PATCH i-g-t 4/5] autoconf: Silence void pointer arithmetic warnings

[Tvrtko Ursulin]

On 28/02/2019 14:31, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-02-28 14:18:27)
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> Meson build does it so make the two symmetrical in this respect.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> ---
>>   configure.ac | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 4f55ea5d0f89..210e2c57df55 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -256,6 +256,8 @@ AC_ARG_ENABLE(werror,
>>                               [Fail on warnings]),
>>                [], [enable_werror=no])
>>   
>> +CWARNFLAGS="$CWARNFLAGS -Wno-pointer-arith"
> 
> \o/

Maybe I am only testing to see who still uses automake. :))

>> +
>>   if test "x$enable_debug" = xyes; then
>>          AS_COMPILER_FLAG([-g3], [DEBUG_CFLAGS="-g3"], [DEBUG_CFLAGS="-g"])
>>          AS_COMPILER_FLAG([-Og], [DEBUG_CFLAGS+=" -Og -Wno-maybe-uninitialized"], # disable maybe-uninitialized due to false positives
>> -- 
> 
> But shouldn't we be using something like the above to verify the flag
> exists?

Definitely true.

Regards,

Tvrtko