[igt-dev] [PATCH i-g-t 7/8] tests/fbcon_fbt: Add and use psr_long_wait_exit() to test updates in PSR

José Roberto de Souza jose.souza at intel.com
Mon Jan 7 19:10:55 UTC 2019


After getting back to fbcon it tests if PSR had a update but since
fbcon can take a while it have some big sleep in place, so what it
is actualy testing is if fbcon is updating the screen.
In this test the update of the screen comes from the fbcon cursor
blinking, the problem is that 40ms is a small interval to detect
cursor blinking and the test can fail some times, so a bigger timeout
to wait for exit is need.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
---
 lib/igt_psr.c         | 5 +++++
 lib/igt_psr.h         | 1 +
 tests/kms_fbcon_fbt.c | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/igt_psr.c b/lib/igt_psr.c
index 82012e6d..28e7e99c 100644
--- a/lib/igt_psr.c
+++ b/lib/igt_psr.c
@@ -47,6 +47,11 @@ bool psr_wait_exit(int debugfs_fd)
 	return igt_wait(psr_active(debugfs_fd, false), 40, 10);
 }
 
+bool psr_long_wait_exit(int debugfs_fd)
+{
+	return igt_wait(psr_active(debugfs_fd, false), 500, 10);
+}
+
 static ssize_t psr_write(int debugfs_fd, const char *buf)
 {
 	return igt_sysfs_write(debugfs_fd, "i915_edp_psr_debug", buf,
diff --git a/lib/igt_psr.h b/lib/igt_psr.h
index d3336c2d..d52a7e08 100644
--- a/lib/igt_psr.h
+++ b/lib/igt_psr.h
@@ -32,6 +32,7 @@
 
 bool psr_wait_entry(int debugfs_fd);
 bool psr_wait_exit(int debugfs_fd);
+bool psr_long_wait_exit(int debugfs_fd);
 bool psr_enable(int debugfs_fd);
 bool psr_disable(int debugfs_fd);
 bool psr_sink_support(int debugfs_fd);
diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index 3e218dc8..cdba1c6e 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -198,7 +198,7 @@ static bool psr_wait_until_enabled(int debugfs_fd)
 
 static bool psr_wait_until_update(int debugfs_fd)
 {
-	return psr_wait_exit(debugfs_fd);
+	return psr_long_wait_exit(debugfs_fd);
 }
 
 static void disable_features(int debugfs_fd)
-- 
2.20.1



More information about the igt-dev mailing list