[igt-dev] [PATCH i-g-t 7/8] tests/fbcon_fbt: Add and use psr_long_wait_exit() to test updates in PSR

[Souza, Jose]

On Mon, 2019-01-07 at 20:41 +0000, Chris Wilson wrote:
> Quoting José Roberto de Souza (2019-01-07 19:10:55)
> > After getting back to fbcon it tests if PSR had a update but since
> > fbcon can take a while it have some big sleep in place, so what it
> > is actualy testing is if fbcon is updating the screen.
> > In this test the update of the screen comes from the fbcon cursor
> > blinking, the problem is that 40ms is a small interval to detect
> > cursor blinking and the test can fail some times, so a bigger
> > timeout
> > to wait for exit is need.
> 
> So what happens if you disable the cursor blink?

It would fail, I can add a patch on top saving the previous state of
/sys/class/graphics/fbcon/cursor_blink enabling it and then restoring.

> Do you actually need to
> open the fbdev and draw something to ensure the path you want
> exercised
> is?

Paulo was the one that wrote the test he can answer better but I guess
he wanted to test if fbcon would show up after draw to fbdev and
teardown.

> -Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20190108/3d506555/attachment.sig>