[igt-dev] [RFC PATCH v4 3/3] tests: gem_exec_basic: add "exec-ctx" buffer execution demo test

Andi Shyti andi.shyti at intel.com
Tue Jan 15 13:43:34 UTC 2019


Hi Chris,

> > +       struct drm_i915_gem_execbuffer2 execbuf = {
> > +               .buffers_ptr = to_user_pointer(&exec),
> > +               .buffer_count = 1,
> > +               .flags = engine->map_index,
> 
> No. Do not store engine->map_index in the global array, as that is
> per-context and I would like to iterate over different arrays of engines.

OK.

> > +               .rsvd1 = ctx,
> > +       };
> > +
> > +       gem_execbuf(fd, &execbuf);
> 
> This doesn't actually prove anything other than no -EINVAL. How many
> different ways might we have accidentally caused success. Could we feed
> in a known failure execbuf and then look for specific failures? (Hint,
> what happens if handle = 0.)

Of course, thanks!

Andi


More information about the igt-dev mailing list