[igt-dev] [PATCH i-g-t v4 3/3] lib/ioctl_wrapper: Implement __gem_mmap

[Chris Wilson]

Quoting Lukasz Kalamarz (2019-01-15 13:44:49)
> Previous implementation of __gem_mmap__cpu and __gem_mmap_wc only
> differ with setting proper flag for caching. This patch implement
> __gem_mmap, which merge those two functions into one
> v2: Reordered and splited this patch into two separete patches
> v3: Dropped unnecessary check
> v4: Remerge patches again and fixed __gem_mmap description
> 
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> ---
> +static void
> +*__gem_mmap(int fd, uint32_t handle, uint64_t offset, uint64_t size, unsigned int prot, uint64_t flags)
> +{
> +       struct drm_i915_gem_mmap arg;

I would have taken the opportunity to use arg = {
	.handle = handle,
	.etal
}.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris