[igt-dev] [PATCH i-g-t 08/21] benchmarks/wsim: Handle a parse error

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Jan 16 11:45:38 UTC 2019


On 16/01/2019 11:20, Petri Latvala wrote:
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   benchmarks/gem_wsim.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
> index e0709487..5a4753d9 100644
> --- a/benchmarks/gem_wsim.c
> +++ b/benchmarks/gem_wsim.c
> @@ -483,6 +483,14 @@ parse_workload(struct w_arg *arg, unsigned int flags, struct workload *app_w)
>   				goto add_step;
>   			}
>   
> +			if (!field) {

field has already been checked to be valid in this block:

		if ((field = strtok_r(fstart, ".", &fctx))) {

Regards,

Tvrtko

> +				if (verbose)
> +					fprintf(stderr,
> +						"Parse error at step %u!\n",
> +						nr_steps);
> +				return NULL;
> +			}
> +
>   			tmp = atoi(field);
>   			if (tmp < 0) {
>   				if (verbose)
> 


More information about the igt-dev mailing list