[igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

[Chris Wilson]

Quoting Deepak Singh Rawat (2019-01-16 16:11:16)
> On Wed, 2019-01-16 at 00:42 -0800, Chris Wilson wrote:
> > Quoting Deepak Rawat (2019-01-16 00:22:29)
> > > For tests using gem specific buffer tiling, add a call to
> > > igt_require_gem so that these tests don't fail at later stage.
> > 
> > KMS operates independently from GEM on i915. So long as you are not
> > calling gem_execbuf, it should continue to work even if we disable
> > the
> > GPU, i.e. igt_require_gem() should not be required here (afaik).
> > -Chris
> 
> gem_set_tiling() calls an i915 private IOCTL which I think would fail
> when GEM is disabled or on other drivers. So I guess either have a
> igt_require_gem() or perhaps GEM specific private IOCTL calls SKIP on
> other drivers.

Ah, you want igt_require(is_i915_device(fd)), or introduce something
like igt_require_i915(fd). Even better if such specifics are removed, or
moved to a subtest group that are clearly device specific.
-Chris