[igt-dev] [PATCH i-g-t 2/3] igt/kms_addfb_basic: Call igt_require_gem for gem specific tiling

[Deepak Singh Rawat]

On Wed, 2019-01-16 at 16:44 +0000, Chris Wilson wrote:
> It's not just testing a backend tiling format, but also the
> corresponding I915_FORMAT_MOD. It won't generalise more than a
> starting
> point for testing other backend specific DRM_FORMAT_MODIFIERS.
> 
> That addfb_expected_ret() is bogus. A different backend may reuse the
> same value as I915_FORMAT_MOD_Y_TILED for a completely different
> purpose, that ends up being valid for the given addfb.
> 
> My reading is addfb25_tests(); addfb25_ytile(); tiling_tests(); are
> all
> i915-specific and should be placed in an i915 subtest group. And that
> we
> should try to extract the (one?) generic addfb25 tests.
> -Chris

Thanks for the explanation. I agree.