[igt-dev] [PATCH i-g-t] lib: Include the size in the error message for mlock

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 22 18:17:28 UTC 2019


Knowing how much we tried to allocate would be useful if one should need
to debug why it failed.

References: https://bugs.freedesktop.org/show_bug.cgi?id=109439
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 lib/igt_aux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 1250d5c5f..2e2d552b5 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -1080,14 +1080,14 @@ void igt_lock_mem(size_t size)
 
 	locked_mem = malloc(locked_size);
 	igt_require_f(locked_mem,
-		      "Could not allocate enough memory to lock.\n");
+		      "Could not malloc %zdMiB for locking.\n", size);
 
 	/* write into each page to ensure it is allocated */
 	for (i = 0; i < locked_size; i += pagesize)
 		locked_mem[i] = i;
 
 	ret = mlock(locked_mem, locked_size);
-	igt_assert_f(ret == 0, "Could not lock memory into RAM.\n");
+	igt_assert_f(ret == 0, "Could not mlock %zdMiB.\n", size);
 }
 
 /**
-- 
2.20.1



More information about the igt-dev mailing list