[igt-dev] [PATCH i-g-t] tests/core_auth: Merge getclient subtests

[Emil Velikov]

On Wed, 23 Jan 2019 at 11:31, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>
> Emil has another auth test which could use the check_auth function, so
> best to merge them all.
>
> We need a subtest group and put the tests which need to fully control
> who's master and how many open drm fd there are first.
>
> Cc: Emil Velikov <emil.l.velikov at gmail.com>

Acked-by: Emil Velikov <emil.velikov at collabora.com>

Ack. on the idea. Pointing out some bits that seem off below.
I would _not_ bother with any of them here, although they may be worth
addressing at some point.

> +       igt_subtest("getclient-master-drop") {
> +               int fd = drm_open_driver(DRIVER_ANY);
> +               int fd2 = drm_open_driver(DRIVER_ANY);
> +
> +               igt_assert(check_auth(fd2) == true);
> +
> +               close(fd);
> +
> +               igt_assert(check_auth(fd2) == true);
> +
> +               close(fd2);
Either a comment is missing here, something seems wrong ... not sure.
 - test is called "master-drop", yet we check the authentication being
"dropped".
 - authentication is always set because we run as root
 - two clients are present, yet we only ever check one of them
 - there is no means to drop authentication for a given client - be
that userspace or in-kernel API

HTH
Emil